HlslParseContext should respect global uniform block name override by intermediate - #3949
Closed
MohammadMDSA wants to merge 1 commit into
Closed
HlslParseContext should respect global uniform block name override by intermediate#3949MohammadMDSA wants to merge 1 commit into
MohammadMDSA wants to merge 1 commit into
Conversation
|
|
dnovillo
requested changes
Jul 16, 2026
dnovillo
left a comment
dnovillo
left a comment
Collaborator
There was a problem hiding this comment.
There are no test exercising this new functionality. Could you add some?
| const char* HlslParseContext::getGlobalUniformBlockName() const | ||
| { | ||
| const char* name = intermediate.getGlobalUniformBlockName(); | ||
| if (std::string(name) == "") |
Collaborator
There was a problem hiding this comment.
This is allocating a string just to compare against an empty literal. Please compare name[0] == '\0'.
Author
|
Hey @dnovillo I'd love to, but because of the agreement I've signed with my workplace, I can no longer contribute to this repo. I am so sorry |
Collaborator
OK, thanks. Absolutely fine. In that case, it's probably better to close this PR. If in the future you happen to be able to contribute again, you can re-open it. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HlslParseContext should respect global uniform block name override by intermediate.
Currently global uniform block name resolved by hlsl parse context is always "$Global" (not even "$Globals" for compatibility with DXC). While the TShader accepts override name for the global block and even TParseContext respects it, it wouldn't work with hlsl. With this change, HlslParseContext would also respect the name override.